ECC-1991: GRIB2: stepType for typeOfStatisticalProcessing index processing #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahramn
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #276 +/- ##
========================================
Coverage 87.75% 87.75%
========================================
Files 827 827
Lines 62050 62050
Branches 11018 11018
========================================
Hits 54455 54455
Misses 7595 7595 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jira.ecmwf.int/browse/ECC-1991
In WMO table 4.10 an entry 102, Index processing was added recently, see
https://github.com/wmo-im/GRIB2/blob/master/GRIB2_CodeFlag_4_10_CodeTable_en.csv#L19
If setting the value 102 for typeOfStatisticalProcessing, stepType is not existing and trying to get the value of this key leads to an error.
This branch extends section.1.def and template.4.statistical.def so that stepType=index if typeOfStatisticalProcessing=102.