Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of dumpers to C++ #278

Merged
merged 9 commits into from
Dec 18, 2024
Merged

Conversation

joobog
Copy link
Collaborator

@joobog joobog commented Dec 18, 2024

No description provided.

@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Dec 18, 2024
@shahramn shahramn self-assigned this Dec 18, 2024
@shahramn shahramn merged commit 546c166 into develop Dec 18, 2024
179 of 182 checks passed
@shahramn shahramn deleted the feature/modernisation_dumper branch December 18, 2024 16:52
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.02123% with 636 lines in your changes missing coverage. Please review.

Project coverage is 87.51%. Comparing base (d7f795e) to head (2a20823).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
src/dumper/grib_dumper_class_grib_encode_C.cc 0.00% 170 Missing ⚠️
src/dumper/grib_dumper_class_default.cc 77.13% 75 Missing ⚠️
src/dumper/grib_dumper_class_serialize.cc 67.89% 61 Missing ⚠️
src/dumper/grib_dumper_class_wmo.cc 83.14% 59 Missing ⚠️
src/dumper/grib_dumper_class_debug.cc 84.27% 53 Missing ⚠️
src/dumper/grib_dumper_class_bufr_encode_filter.cc 93.54% 29 Missing ⚠️
src/dumper/grib_dumper_class_bufr_simple.cc 93.27% 29 Missing ⚠️
src/accessor/grib_accessor_class_gen.cc 55.10% 22 Missing ⚠️
src/dumper/grib_dumper_class_bufr_decode_filter.cc 93.02% 21 Missing ⚠️
src/dumper/grib_dumper_class_bufr_encode_C.cc 96.20% 21 Missing ⚠️
... and 13 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #278      +/-   ##
===========================================
- Coverage    87.78%   87.51%   -0.28%     
===========================================
  Files          829      841      +12     
  Lines        62125    61883     -242     
  Branches     11035    11008      -27     
===========================================
- Hits         54539    54156     -383     
- Misses        7586     7727     +141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants