Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.13.6 #139

Merged
merged 38 commits into from
Nov 29, 2024
Merged

Release 5.13.6 #139

merged 38 commits into from
Nov 29, 2024

Conversation

marcosbento
Copy link
Collaborator

No description provided.

marcosbento and others added 30 commits November 8, 2024 09:28
@marcosbento
Add FindCrypt.cmake module
9876f2d 
This allows to find libcrypt.so by full path, and avoid being dependent
on the compiler directory search.

Re ECFLOW-1987
@marcosbento
Avoid reinitialization of ClientInvoker
68ee815
@marcosbento
Use handles to avoid unnecessary memory usage/leak
27d1cdc
@marcosbento
Enable reloading of Mirror configuration
0db490b 
Mirror attribute is reset with the latest configuration when "reload" is used as
value on a Alter Mirror command

Re ECFLOW-1986
@marcosbento
Enable reloading of Aviso configuration
9948ab5 
Re ECFLOW-1986
@marcosbento
Update documentation
5a4ebc1 
Re ECFLOW-1986
@marcosbento
Avoid crash when logging from Mirror/Aviso threads
91730eb 
This ensures that only one thread is able to write to the log at any given instant

Re ECFLOW-1986
@marcosbento
Terminate Mirror/Aviso background threads also when server is shutdown
349c1ac 
Before this change, the background threads were only destroyed when the server state changed from running -> halted.
This introduced an issue, as changing state from halted -> shutdown and running -> shutdown would allow reaching the shutdown state with sometimes running threads.

Re ECFLOW-1986
@marcosbento
Enable reload of Mirror/Aviso configuration ECFLOW-1986
3c97cfe
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
639a3cc
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
01753e5
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
26e4d8e
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
fd73861
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
9a44d1a
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
d0f171c
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
b1de19c
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
e51ac6b
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
a623461
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
e861c2b
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
dc58016
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
be00047
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
477c18f
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
0493878
@iainrussell @marcosbento
Automatic package building ECFLOW-1967
6abdd1a
@marcosbento
Remove commented lines in workflow file
c2cc15e 
- List CMake options one per line

Re ECFLOW-1967
@marcosbento
Enable automatic package building ECFLOW-1967
317db58
@marcosbento
Customise CD triggers
d91bdaf 
- CD can be triggered manually, or automatically whenever a new tag is pushed
- Changes to configuration also trigger an automatic CD run

Re ECFLOW-1967
@marcosbento
Enable SSL only after processing CLI options
1650fc9 
Re ECFLOW-1985
@marcosbento
Create a scaffold library to store basic helper classes
00b1ac8 
Re ECFLOW-1985
@marcosbento
Add tests for handling Client/Server configuration
e559874 
Re ECFLOW-1985
@marcosbento marcosbento changed the title Release 5.13.5 Release 5.13.6 Nov 29, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.85207% with 128 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@e40d0a1). Learn more about missing BASE report.
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
Viewer/ecflowUI/src/VRepeatAttr.cpp 0.00% 29 Missing ⚠️
Viewer/ecflowUI/src/RepeatEditor.cpp 0.00% 25 Missing ⚠️
...ibs/attribute/src/ecflow/attribute/RepeatRange.hpp 74.35% 20 Missing ⚠️
...service/src/ecflow/service/mirror/MirrorClient.cpp 27.77% 13 Missing ⚠️
libs/node/src/ecflow/node/NodeChange.cpp 0.00% 9 Missing ⚠️
libs/node/src/ecflow/node/MirrorAttr.cpp 22.22% 7 Missing ⚠️
libs/core/src/ecflow/core/Chrono.cpp 0.00% 6 Missing ⚠️
libs/node/src/ecflow/node/AvisoAttr.cpp 0.00% 6 Missing ⚠️
libs/attribute/src/ecflow/attribute/RepeatAttr.hpp 37.50% 5 Missing ⚠️
Viewer/ecflowUI/src/NodeViewDelegate.cpp 0.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #139   +/-   ##
=========================================
  Coverage          ?   48.84%           
=========================================
  Files             ?     1184           
  Lines             ?    98267           
  Branches          ?    14778           
=========================================
  Hits              ?    47996           
  Misses            ?    50271           
  Partials          ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento merged commit 3d5d0b7 into master Nov 29, 2024
103 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcosbento @codecov-commenter @iainrussell