Make fypp install/export optional #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wdeconinck
force-pushed
the
feature/fypp-optional-install
branch
from
c2f193e to
54feb73
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35 +/- ##
========================================
Coverage 52.07% 52.07%
========================================
Files 52 52
Lines 4388 4388
========================================
Hits 2285 2285
Misses 2103 2103 ☔ View full report in Codecov by Sentry. |
|
This currently fails the downstream-ci: |
wdeconinck
requested changes
Feb 24, 2024
CMakeLists.txt
Outdated
| install( FILES contrib/fypp-3.0-7895a7e-20200112/bin/fypp DESTINATION libexec RENAME fckit-fypp.py PERMISSIONS ${install_permissions} ) | ||
| if( NOT FYPP ) | ||
| install( FILES contrib/fypp-3.0-7895a7e-20200112/bin/fypp DESTINATION libexec RENAME fckit-fypp.py PERMISSIONS ${install_permissions} ) | ||
| endif() |
There was a problem hiding this comment.
We need to (re)install the externally found fypp as well, so that downstream packages using fckit's macro can use it as well.
awnawab
force-pushed
the
feature/fypp-optional-install
branch
from
c4fde5c to
f49879d
Compare
wdeconinck
force-pushed
the
feature/fypp-optional-install
branch
from
f49879d to
2dc0bd8
Compare
|
@awnawab version 0.11.1 contains this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, fckit will override any local fypp if it is included in a bundle. This can be problematic if a project in that bundle needs a newer version of fypp. This PR changes the default behaviour so that fypp is only installed and exported by fckit if it is not already found.
Could you please tag a release once this PR is approved and merged? I would like to include it in an updated ifs-bundle.