Prevent string out of bounds. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #46 +/- ##
==========================================
Coverage ? 51.17%
==========================================
Files ? 58
Lines ? 4782
Branches ? 449
==========================================
Hits ? 2447
Misses ? 2335
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
I've done another update; I had a failure in saber where there was an attempt to pass a yaml configuration through the routines that had more that 255 characters in total. |
|
Thanks @DJDavies2 !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45. It seems that the code has hardcoded string limits and at some point the strings being passed to fckit are too long for the hardcoded limit. I don't know where those are coming from, but I think it would be better if the string truncated in that case rather than went out of bounds and did undefined behaviour.
I have done this by turning the dummy argument into an assumed shape array which means its bounds are passed in the subroutine call. The loop can then have an upper bound which ensures that the array never goes out of bounds. What do you think?