Propagate dependencies of fypp files #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @marsdeno |
wdeconinck
added a commit
that referenced
this pull request
Dec 19, 2024
* hotfix/0.13.3: Version 0.13.3 FCKIT_VENV: make Python3 check optional if feature is not enabled FCKIT_VENV: simplify caching procedure for cross-platform builds FCKIT_VENV: remove redundant editable build option FCKIT_VENV: only install dependencies from requirements file for offline mode YAML_READER: switch ruamel.yaml.clib to build from source FCKIT_VENV: downgrade setuptools version FCKIT_VENV: enable offline install option YAML_READER: split installation into dependencies and installation from source YAML_READER: remove pytest dependency FCKIT_VENV: only enable if python < 3.12 YAML_READER: only do pip upgrade for python3.8 FYPP: propagate dependencies of fypp files (#50) add_fctest requires cmake 3.12; This disables cmake deprecation warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new design pattern emerging in the IFS is to place commonly used templates in header files and include these in fypp files. CMake does not of course recognise these fypp header files as dependencies, so changes to the template do not re-trigger fypp pre-processing and re-compilation.
One possible remedy is to manually mark the fypp files as depending on the header files. This PR adds the functionality to propagate this dependency through to the fypp preprocessing.