Fix/polytope array parsing #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peshence
force-pushed
the
fix/polytope-date-parsing
branch
from
e3ae4d4 to
ec6da64
Compare
peshence
commented
Mar 7, 2025
Comment on lines
-207
to
-219
| # # Format time as HHMM | ||
| # time_str = f"{hour:02d}{minute:02d}" | ||
| # return time_str | ||
|
|
||
| # Validate hour and minute | ||
| if not (0 <= hour <= 23): | ||
| raise CoercionError("Hour must be between 0 and 23.") | ||
| if not (0 <= minute <= 59): | ||
| raise CoercionError("Minute must be between 0 and 59.") | ||
| if minute != 0: | ||
| # In your test cases, minute must be zero | ||
| raise CoercionError("Minute must be zero.") | ||
|
|
There was a problem hiding this comment.
this code is repeated above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polytope was rejecting string arrays of dates ("yyyymmdd/yyyymmdd/...") due to coercion converting then to an array, and us reusing the mars date checking