Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor cyclic transformation #109

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

mathleur
Copy link
Member

No description provided.

@mathleur
Copy link
Member Author

Put the different cyclic ranges calculations within the find_indexes_between function of the cyclic transformation

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.33735% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 89.34%. Comparing base (00f0161) to head (47f8fd0).

❗ Current head 47f8fd0 differs from pull request most recent head a65c2f1. Consider uploading reports for the commit a65c2f1 to get more accurate results

Files Patch % Lines
polytope/datacube/datacube_axis.py 75.00% 6 Missing ⚠️
...mations/datacube_reverse/reverse_axis_decorator.py 75.00% 6 Missing ⚠️
...ormations/datacube_cyclic/cyclic_axis_decorator.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #109      +/-   ##
===========================================
+ Coverage    87.68%   89.34%   +1.65%     
===========================================
  Files           88       83       -5     
  Lines         7098     6934     -164     
===========================================
- Hits          6224     6195      -29     
+ Misses         874      739     -135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathleur mathleur merged commit c3f51b3 into develop Mar 5, 2024
6 checks passed
@mathleur mathleur deleted the feature/refactor_cyclic_transformation branch March 5, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants