Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config and user_config options to pyfdb #25

Merged
merged 14 commits into from
Oct 8, 2024

Conversation

TomHodson
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 44.26230% with 34 lines in your changes missing coverage. Please review.

Project coverage is 36.07%. Comparing base (0527eb8) to head (a41a611).

Files with missing lines Patch % Lines
pyfdb/pyfdb.py 0.00% 34 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #25      +/-   ##
===========================================
+ Coverage    32.46%   36.07%   +3.61%     
===========================================
  Files            5        6       +1     
  Lines          308      352      +44     
===========================================
+ Hits           100      127      +27     
- Misses         208      225      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@simondsmart simondsmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. I also notice that the python-qa ci check is failing. Please fix.

pyfdb/pyfdb.py Show resolved Hide resolved
pyfdb/pyfdb.py Show resolved Hide resolved
@TomHodson TomHodson requested a review from simondsmart October 8, 2024 09:50
@TomHodson TomHodson force-pushed the feature/direct_config branch from d973261 to b9d6858 Compare October 8, 2024 10:09
@simondsmart simondsmart merged commit 8a70b73 into develop Oct 8, 2024
97 checks passed
@TomHodson TomHodson deleted the feature/direct_config branch October 8, 2024 12:34
@TomHodson TomHodson restored the feature/direct_config branch October 8, 2024 13:22
@TomHodson TomHodson deleted the feature/direct_config branch October 8, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants