[WIP] Started separation of FDB and FDB api classes #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #30 +/- ##
===========================================
- Coverage 36.07% 27.60% -8.48%
===========================================
Files 6 7 +1
Lines 352 460 +108
===========================================
Hits 127 127
- Misses 225 333 +108 ☔ View full report in Codecov by Sentry. |
tbkr
force-pushed
the
feature/api_separation
branch
8 times, most recently
from
0da1ddb to
0986281
Compare
Due to the poor encapsulation and leakage of ffi functionality into the FDB python class, FDB and FDBApi classes has been separated to guarantee a better separation of concerns. This is work in progress.
tbkr
force-pushed
the
feature/api_separation
branch
from
0986281 to
b1259db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the poor encapsulation and leakage of ffi functionality into the FDB python class, FDB and FDBApi classes has been separated to guarantee a better separation of concerns.
This is work in progress.