Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/eccodes 24 #33

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Feature/eccodes 24 #33

merged 3 commits into from
Nov 6, 2024

Conversation

tbkr
Copy link
Collaborator

@tbkr tbkr commented Nov 6, 2024

Switched pyeccodes to eccodes-python.

@tbkr tbkr force-pushed the feature/eccodes_24 branch 2 times, most recently from df1ca1c to e4dfe95 Compare November 6, 2024 08:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (546de32) to head (aadc9f0).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #33   +/-   ##
========================================
  Coverage    94.77%   94.77%           
========================================
  Files            3        3           
  Lines          134      134           
========================================
  Hits           127      127           
  Misses           7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tbkr tbkr requested a review from TomHodson November 6, 2024 08:43
@tbkr tbkr mentioned this pull request Nov 6, 2024
Copy link
Collaborator

@TomHodson TomHodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. I have one comment, since eccodes is not actually needed for pyfdb, only for the tests, is it worth making it an optional dependency?

The syntax for setup.py would be:

setup(
    name="Package-A",
    ...,
    extras_require={
        "test": ["eccodes"],
    },
)

and the installation command for optional dependencies looks like:
pip install pyfdb[tests] or pip install -e ".[tests]"

@tbkr tbkr force-pushed the feature/eccodes_24 branch from e4dfe95 to f0fbe8d Compare November 6, 2024 16:50
@tbkr
Copy link
Collaborator Author

tbkr commented Nov 6, 2024

I added the proposed changes to the testing dependencies to the pyproject.toml file @TomHodson. Thanks a lot for your input, as always :)

EDIT: Reverted the changes because the build pipeline is installing the default target and therefore not installing eccodes but testing later on.

Dependencies like eccodes-python are now only needed for testing dependency group.
@tbkr tbkr force-pushed the feature/eccodes_24 branch from f0fbe8d to aadc9f0 Compare November 6, 2024 17:31
@tbkr tbkr merged commit 004cab4 into develop Nov 6, 2024
99 checks passed
@tbkr tbkr deleted the feature/eccodes_24 branch November 8, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants