Reassignment throws error in calculate_cos_solar_zenith_angle_integrated

[jarataraj]

The Bug

While attempting to use calculate_cos_solar_zenith_angle_integrated via xr.apply_ufunc as in:

integralCzaEaHour = [xr.apply_ufunc(thermofeel.calculate_cos_solar_zenith_angle_integrated, ds.lat, ds.lon, time.dt.year, 
    time.dt.month, time.dt.day, time.dt.hour, 0, 1) for time in ds.time]

I get the following error:
ValueError: non-broadcastable output operand with shape (571,1) doesn't match the broadcast shape (571,1440)

The Solution

An answer to a related stack overflow question suggests eliminating the += operator, as in changing a += b to a = a + b. Sure enough, when I change line 316 in thermofeel.py from integral += w[n] * calculate_cos_solar_zenith_angle( to integral = integral + w[n] * calculate_cos_solar_zenith_angle(, everything works as expected. The stack overflow answer includes an explanation as to why.

[tlmquintino]

@jarataraj many thanks for pointing out this issue.
I think it makes sense to apply the fix. Would you be able to provide a pull request with solution?

[jarataraj]

@tlmquintino Will do! Is it ok for me to change all instances of a += b and similar to a = a + b and similar? Or should I just apply the fix to calculate_cos_solar_zenith_angle_integrated? I know I got the error for two different thermofeel functions but I can't remember what the other was and haven't yet tested all of them.

[tlmquintino]

@jarataraj sorry for the late reply, I've been traveling.
Yes please do go ahead and I think it makes sense doing that substitution everywhere.

[tlmquintino]

this is now fixed as part of the code moved to another python module (earthkit-meteo) and the rest of the fixed was added directly to develop branch.