Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix APY calculation for quicksilver #61

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

ajansari95
Copy link
Contributor

  • quicksilver does not use sdk mint module, current calc consider it
  • it uses osmosis mint module - have replaced the APR calc
  • Not really sure if the changes are exhaustive? please guide through other changes needed (if any)

@tombeynon
Copy link
Contributor

This looks great, thank you @ajansari95! Since the code matches the Osmosis implementation, could we do something similar to Evmos and Echelon? i.e. two cases handled by a single block of code, and use path for the osmosis/quicksilver first path segment?

I'm happy to finish up your PR if you'd prefer, appreciate the effort!

@ajansari95
Copy link
Contributor Author

most welcome @tombeynon, have made the changes as requested.

@tombeynon
Copy link
Contributor

Perfect! I'm going to release this to the site now to give it a test, and will merge the PR soon as part of a full release.

You should see the Quicksilver APR update in 30 mins or so. Thanks so much again for the PR 🚀

@ajansari95
Copy link
Contributor Author

Thank you @tombeynon, much appreciated 🙌

@ajansari95
Copy link
Contributor Author

Hey @tombeynon, following up on this 😄

@tombeynon
Copy link
Contributor

Hey @ajansari95 this is live on cosmos.directory and restake.app - you can see the APR now. I just haven't merged the PR and done a full release yet; is that holding you up?

FYI I'm also going to set Quicksilver to be 1 per day max compounding. Operators can run it more often, but the APY figure will only reflect once per day compounding. I was told that QS is epoch based like Osmosis so APY shouldn't increase with more compounding.

@tombeynon tombeynon merged commit 6efca0b into eco-stake:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants