Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edp-webserver的重构 #132

Closed
leeight opened this issue Feb 28, 2014 · 15 comments
Closed

edp-webserver的重构 #132

leeight opened this issue Feb 28, 2014 · 15 comments
Assignees
Milestone

Comments

@leeight
Copy link
Member

leeight commented Feb 28, 2014

RT

@leeight leeight added this to the 0.8.0 milestone Feb 28, 2014
@leeight
Copy link
Member Author

leeight commented Mar 4, 2014

@otakustay @ecomfe/team-edp 讨论吧

@PengXing
Copy link

PengXing commented Mar 5, 2014

有初步的思路么?

@leeight
Copy link
Member Author

leeight commented Mar 5, 2014

原来周报专家也来了,要不你抽空整一下吧。立理曾经提到过想参考expressjs的方式来搞。

@otakustay
Copy link
Member

暂时就2个:

  1. 底下用connectkoa,我们只是在上面做中间件而不是再把底层翻一遍
  2. 路径匹配用expressjs风格

@leeight
Copy link
Member Author

leeight commented Mar 5, 2014

恩,同意,虽然不明白koa是干啥的。另外,需要考虑方便写ut。

@firede
Copy link
Member

firede commented Mar 5, 2014

同意。
另外,koa 不是要依赖 node0.11.x 版本么,和 edp 不一致。

@otakustay
Copy link
Member

那就connect吧,因为webserver的原型出现得比connect早,所以第一个版本没用……既然思路上也和connect几乎一致,就用着吧

@leeight
Copy link
Member Author

leeight commented Mar 5, 2014

@PengXing 你有事情做了。

@leeight
Copy link
Member Author

leeight commented Mar 5, 2014

@PengXing baidu-zhixin-sdk应该想办法合并到edp-webserver里面去的吧

@PengXing
Copy link

PengXing commented Mar 5, 2014

好,我来搞,合并进去吧,但是渲染模板的逻辑做另外一次请求到我搭建的一个服务上去了

@PengXing
Copy link

PengXing commented Mar 7, 2014

webserver里的 autolessproxy 我觉得并不算是connect的中间件,而算是给中间件调用的处理函数而已

@leeight
Copy link
Member Author

leeight commented Mar 8, 2014

好,你说了算。

leeight added a commit to ecomfe/edp-webserver that referenced this issue Mar 19, 2014
@leeight
Copy link
Member Author

leeight commented Mar 24, 2014

@PengXing

edp INFO Forward request /api/js/users/current to jx-cb-bk00.jx.baidu.com:8280/api/js/users/current
edp INFO Forward request /api/tool/static/sysWebInfo to jx-cb-bk00.jx.baidu.com:8280/api/tool/static/sysWebInfo
Error: Response timeout
    at IncomingMessage.<anonymous> (/Users/leeight/local/leeight.github.com/edp-cli/edp-webserver/node_modules/connect/node_modules/connect-timeout/index.js:39:17)
    at IncomingMessage.EventEmitter.emit (events.js:95:17)
    at null._onTimeout (/Users/leeight/local/leeight.github.com/edp-cli/edp-webserver/node_modules/connect/node_modules/connect-timeout/index.js:34:11)
    at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
127.0.0.1 - - [Mon, 24 Mar 2014 02:05:10 GMT] "GET /api/js/users/current/status?_=1395626705781 HTTP/1.1" 503 465 "http://admtest.baidu.com:8280/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1905.2 Safari/537.36"
Error: Response timeout
    at IncomingMessage.<anonymous> (/Users/leeight/local/leeight.github.com/edp-cli/edp-webserver/node_modules/connect/node_modules/connect-timeout/index.js:39:17)
    at IncomingMessage.EventEmitter.emit (events.js:95:17)
    at null._onTimeout (/Users/leeight/local/leeight.github.com/edp-cli/edp-webserver/node_modules/connect/node_modules/connect-timeout/index.js:34:11)
    at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
127.0.0.1 - - [Mon, 24 Mar 2014 02:05:10 GMT] "GET /favicon.ico HTTP/1.1" 503 465 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1905.2 Safari/537.36"

http.js:691
    throw new Error('Can\'t set headers after they are sent.');
          ^
Error: Can't set headers after they are sent.
    at ServerResponse.OutgoingMessage.setHeader (http.js:691:11)
    at ServerResponse.res.setHeader (/Users/leeight/local/leeight.github.com/edp-cli/edp-webserver/node_modules/connect/lib/patch.js:63:22)
    at ServerResponse.<anonymous> (/Users/leeight/local/leeight.github.com/edp-cli/edp-webserver/node_modules/connect/lib/patch.js:80:14)
    at Array.forEach (native)
    at ServerResponse.res.writeHead (/Users/leeight/local/leeight.github.com/edp-cli/edp-webserver/node_modules/connect/lib/patch.js:79:28)
    at ServerResponse.res.writeHead (/Users/leeight/local/leeight.github.com/edp-cli/edp-webserver/node_modules/connect/node_modules/connect-timeout/index.js:52:17)
    at ServerResponse.writeHeader (http.js:1208:18)
    at Array.1 (/Users/leeight/local/leeight.github.com/edp-cli/edp-webserver/lib/resource.js:35:18)
    at nextHandler (/Users/leeight/local/leeight.github.com/edp-cli/edp-webserver/lib/handler.js:65:30)
    at Object.context.start (/Users/leeight/local/leeight.github.com/edp-cli/edp-webserver/lib/handler.js:50:13)

@PengXing
Copy link

我来看看。。。

@leeight
Copy link
Member Author

leeight commented Mar 31, 2014

@PengXing 重构结束了吧?我把ISSUE关闭了?

@leeight leeight closed this as completed Apr 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants