Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class for risky-asset consumers #1012

Merged
merged 4 commits into from
Jun 3, 2021

Conversation

Mv77
Copy link
Contributor

@Mv77 Mv77 commented May 25, 2021

The only model with a risky asset to store savings currently in HARK is ConsPortfolioModel. However, there are various additional models of this type that are works in progress:

  • My own two-asset model here.
  • A portfolio model that takes housing into account. @alanlujan91, @llorracc and I are working on it.

It would be useful to have a class representing agents with risky assets, from which ConsPortfolio and these two works-in-progress could inherit. This PR implements such class by taking the general methods from ConsPortfolio, and makes ConsPortfolio inherit from it.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@codecov-commenter
Copy link

Codecov Report

Merging #1012 (13cd47d) into master (6d157ea) will decrease coverage by 0.00%.
The diff coverage is 75.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
- Coverage   71.67%   71.66%   -0.01%     
==========================================
  Files          63       64       +1     
  Lines        9197     9234      +37     
==========================================
+ Hits         6592     6618      +26     
- Misses       2605     2616      +11     
Impacted Files Coverage Δ
HARK/ConsumptionSaving/ConsRiskyAssetModel.py 74.02% <74.02%> (ø)
HARK/ConsumptionSaving/ConsPortfolioModel.py 66.08% <100.00%> (-1.20%) ⬇️
HARK/ConsumptionSaving/ConsIndShockModelFast.py 51.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d157ea...13cd47d. Read the comment docs.

@llorracc llorracc merged commit 00ce66a into econ-ark:master Jun 3, 2021
@Mv77 Mv77 deleted the ContribMod/RiskyAssetClass branch June 9, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants