Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Renames X and pmf #1159

Closed
wants to merge 2 commits into from
Closed

WIP Renames X and pmf #1159

wants to merge 2 commits into from

Conversation

alanlujan91
Copy link
Member

@alanlujan91 alanlujan91 commented Aug 3, 2022 •
edited
Loading

See #1156 and #1051

To be merged after #1156

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@alanlujan91
rename
2eed6ad 
X -> data
pmf -> prob
@sbenthall
Copy link
Contributor

Given the complexity of the other PR, it might be better to make this change before the xarray work.

I.e., we should settle on interface design choices for the (discrete) distributions, and then later worry about how to implement them.

@sbenthall sbenthall mentioned this pull request Aug 4, 2022
Merged
3 tasks
@alanlujan91 alanlujan91 marked this pull request as draft August 4, 2022 15:01
@alanlujan91 alanlujan91 mentioned this pull request Aug 16, 2022
Merged
@sbenthall sbenthall added this to the 0.13.0 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alanlujan91 @sbenthall