-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniform endpoints #1180
Uniform endpoints #1180
Conversation
include endpoints in approximation
Codecov ReportBase: 72.79% // Head: 72.81% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
+ Coverage 72.79% 72.81% +0.01%
==========================================
Files 72 72
Lines 11793 11800 +7
==========================================
+ Hits 8585 8592 +7
Misses 3208 3208
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merge conflict and CHANGELOG update please |
HARK/distribution.py
Outdated
) | ||
|
||
if endpoint: | ||
atoms = np.linspace(self.bot, self.top, N) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these points equiprobable with the endpoints included, and if not, how can the pmv
be accurately formed?
@llorracc : what about infinitessimally sized point masses for the endpoints? |
#todo for other distributions adding endpoints (truncated lognormal) |
Addresses: #1178
Please ensure your pull request adheres to the following guidelines: