[Bug-fix] Mortality and t_cycle when shocks are read

[Mv77]

Some months ago I did some work on the functionality that allows you to read pre-computed shocks.

I made a crucial omission of resetting t_age and not t_cycle when killing agents when one reads a shock that kills them.

This is a pretty serious bug. The upside is that it was introduced not that long ago in the grand scheme of things (9 months), and that the read_shocks feature is not used as often. I hope this did not cause trouble to anyone...

This patch fixes the issue.

• Tests for new functionality/models or Tests to reproduce the bug-fix in code.
• Updated documentation of features that add new functionality.
• Update CHANGELOG.md with major/minor changes.

[codecov-commenter]

Codecov Report

Base: 72.71% // Head: 72.79% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (c635830) compared to base (73f6521).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
+ Coverage   72.71%   72.79%   +0.08%     
==========================================
  Files          72       72              
  Lines       11764    11793      +29     
==========================================
+ Hits         8554     8585      +31     
+ Misses       3210     3208       -2     

Impacted Files	Coverage Δ
HARK/Calibration/Income/IncomeTools.py	92.79% <100.00%> (ø)
...nsumptionSaving/tests/test_IndShockConsumerType.py	78.55% <100.00%> (+1.81%)	⬆️
HARK/core.py	91.48% <100.00%> (+0.01%)	⬆️
HARK/ConsumptionSaving/ConsIndShockModel.py	79.47% <0.00%> (+0.20%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[alanlujan91]

@sbenthall this might be related to #1084

[llorracc]

@wdu9, could you review this?

[Mv77]

@sbenthall this might be related to #1084

Maaaybe but the bug was introduced after that issue was created. So maybe related but unlikely to fix it.

[wdu9]

Looks good.

[Mv77]

I've corrected the typo that Will identified and merged the latest master.

I'll merge after tests are done if there are no objections.