Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time-varying risky distribution #1262

Merged
merged 7 commits into from
May 3, 2023
Merged

Conversation

Mv77
Copy link
Contributor

@Mv77 Mv77 commented Apr 28, 2023

Addresses the critiques in #1255, and allows a time-varying risky-asset distribution.

I am marking this as a work in progress because, having to do with time-varying parameters, this runs into the whole t_age, t_cycle, cycles, t_age+1 issue and I would like to talk through it.

Do not merge yet.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 96.66% and project coverage change: +0.15 🎉

Comparison is base (99e1986) 73.28% compared to head (c78d09a) 73.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1262      +/-   ##
==========================================
+ Coverage   73.28%   73.43%   +0.15%     
==========================================
  Files          77       77              
  Lines       12825    12845      +20     
==========================================
+ Hits         9399     9433      +34     
+ Misses       3426     3412      -14     
Impacted Files Coverage Δ
HARK/ConsumptionSaving/ConsRiskyAssetModel.py 44.36% <92.30%> (+3.62%) ⬆️
...ConsumptionSaving/tests/test_ConsPortfolioModel.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mv77 Mv77 changed the title [WIP] Time-varying risky distribution Time-varying risky distribution May 3, 2023
@Mv77
Copy link
Contributor Author

Mv77 commented May 3, 2023

Merging as this found no opposition on the 05/03/2023 call.

@Mv77 Mv77 merged commit 0b108f5 into econ-ark:master May 3, 2023
@Mv77 Mv77 deleted the plumbing/risky-dstn branch May 4, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants