Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing DBlock, working it into the ATMC simulator, see #1371 #1411

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

sbenthall
Copy link
Contributor

@sbenthall sbenthall commented Apr 16, 2024

This PR works towards #1371 , namely to align HARK's modeling capabilities with the needs of the 'DYNARK' language, as anticipated based on last year's research sprint.

This PR introduces a new modeling component, a DBlock, which can include:

  • a name
  • parameters: mapping variable names to values
  • shocks: mapping variable names to distributions
  • dynamics: mapping variable names to transition functions or declarations of Control

This is a trivial change on top of the earlier generic monte carlo functionality, just repackaging the data into a 'block' unit. But this PR updates the GMC simulator, and introduces new automated testing of the model and block objects.

This is a necessary step towards future work, which is reserved for other PRs, including:

  • configuring an ATMC Simulator with multiple, linked blocks
  • including AgentType configuration (such as agent count) optionally in a model definition
  • multi-agent-type models supported by the ATMC siimulator

The 'DBlock' construct is based on Matt's original spec from some time ago. It admittedly does not have all the bells and whistles of the notional nohablo style block. However, it captures all of the currently available simulator functionality. The purpose of this step is to begin the co-development of the block definition with the monte carlo simulator, which determines its semantics.

This PR is ready for review.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@sbenthall sbenthall requested a review from mnwhite April 16, 2024 14:56
@sbenthall
Copy link
Contributor Author

ruff is being stupid.

@sbenthall
Copy link
Contributor Author

tests are passing now.

@mnwhite
Copy link
Contributor

mnwhite commented Apr 22, 2024

Per meeting discussion, this is mostly harmless. Don't panic.

@mnwhite mnwhite merged commit 5762cad into econ-ark:master Apr 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants