Delete old demo files #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two folders inside of /ConsumptionSaving that contain model demos. To my knowledge, all of these have been turned into DemARK notebooks other than TryAlternativeParameters, which has no explanation or documentation. I'm not even sure when or why it was put into HARK. This commit removes these old files.
|
Hi @mnwhite, I'm going through PRs and adding a "needs release notes" label. Can you provide a one sentence summary of your changes, ideally by editing the issue itself (as opposed to leaving a comment), clearly labeled with "For release notes" or similar? Remember to specify if there are breaking changes in the PR. I'm not going to leave a comment like this on every merged PR of yours, but you can find a full list (well, full once I'm done tagging) here. |
|
Release note: Moved old "demo" files to DemARK or other appropriate places |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two folders inside of /ConsumptionSaving that contain model demos. To my knowledge, all of these have been turned into DemARK notebooks other than TryAlternativeParameters, which has no explanation or documentation. I'm not even sure when or why it was put into HARK.
This commit removes these old files.
Release notes: Simple example applications of some consumption-saving models that were in /HARK/ConsumptionSaving/Demos and /HARK/ConsumptionSaving/ConsIndShockModelDemos have been removed. These examples have been converted to Jupyter notebooks and can be found in the DemARK.