Changed hardcoded updateAFunc parameters into proper parameters #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Four parameters that govern how CobbDouglasEconomy.updateAFunc works were defined locally, within the method, but are now attributes to be assigned at init (or at least before the user tries to solve): - update_weight --> DampingFac, now defined complementarily - verbose --> verbose - discard_periods --> T_discard - max_loops --> max_loops To prevent this from being a breaking change, init method writes old hardcoded values if omitted from passed inputs. This will be improved with a warning later. Untested, as it turns out Anaconda3 is incorrectly installed on this computer.
Put new parameters in dictionaries in ConsumerParameters.py. Also added necessary lines to MarkovCobbDouglasEconomy and fixed one output description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four parameters that govern how CobbDouglasEconomy.updateAFunc works
were defined locally, within the method, but are now attributes to be
assigned at init (or at least before the user tries to solve):
To prevent this from being a breaking change, init method writes old
hardcoded values if omitted from passed inputs. This will be improved
with a warning later.
For release notes: "Parameters of ConsAggShockModel.CobbDouglasEconomy.updateAFunc and ConsAggShockModel.CobbDouglasMarkovEconomy.updateAFunc that govern damping and the number of discarded 'burn-in' periods were previously hardcoded, now proper instance-level parameters."