Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated Solution code, use HARKobject in the codebase #772

Merged
merged 4 commits into from
Aug 7, 2020
Merged

remove deprecated Solution code, use HARKobject in the codebase #772

merged 4 commits into from
Aug 7, 2020

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Jul 23, 2020 •
edited
Loading

fixes #772

@MridulS MridulS requested a review from mnwhite July 23, 2020 16:22
@MridulS
Copy link
Member Author

MridulS commented Jul 23, 2020

@mnwhite Can you have a look here and merge this? There were a couple of places where the ModelSolution Class inherited from Solution, I have changed it to inherit HARKobject now.

@MridulS MridulS requested review from mnwhite and removed request for mnwhite July 28, 2020 16:00
@llorracc llorracc added the Ready-To-Merge Has been reviewed and when branch is updated and checks pass it should be merged label Aug 6, 2020
@MridulS MridulS merged commit f79568c into econ-ark:master Aug 7, 2020
@sbenthall sbenthall mentioned this pull request Aug 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnwhite mnwhite Awaiting requested review from mnwhite

Assignees

@MridulS MridulS

@mnwhite mnwhite

Labels
Ready-To-Merge Has been reviewed and when branch is updated and checks pass it should be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MridulS @llorracc @mnwhite