calculate calcEndOfPrdvP in IndShock solver with calcExpectation #896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to take a small step towards #625 by replacing the computation of
calcEndOfPrdvP
in the IndShock solver with a single call to calcExpectation.This currently has two issues:
aNrmNow
array in that case has a different shape for some reason.I'm not sure why the numerical values are off here.
One next step would be to write more thorough automated tests for
calcExpectations
.But it's possible that @mnwhite might be able to eyeball it and see if I'm doing something wrong.
The goal of this work, concretely, is to replace much of the work done in
setAndUpdateValues
andprepareToCalcEndOfPrdvP
throughout the library with succinct calls tocalcExpectations
. I think this would simplify things a great deal.