Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-2493] Change chart to use quote volume, set default visible range #409

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

CRBl69
Copy link
Collaborator

@CRBl69 CRBl69 commented Nov 22, 2024

Description

  • Change chart to use quote volume
  • Set the chart's default visible range
  • Update the number of swaps/chats delivered on load (100 => 25)
  • Change default timeframe to 1m from 5m

@CRBl69 CRBl69 requested a review from xbtmatt November 22, 2024 20:53
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 6:57pm
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 6:57pm

Copy link
Collaborator

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove unused fields from swap/chat events when fetching from the indexer (based on what the market page uses, it's like 4-5 fields total, you can get rid of most of the market state/periodic state event stuff)
  2. Cache the swap/chat data like we do with candlesticks
  3. Consolidate the safe number parsing logic into a single function with a try/catch that returns false if it throws an error

Copy link
Collaborator

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on eng call: split this PR up into two PRs where the first one is simply the more basic performance optimizations with infinite load, and the second is the generic, parameterizable Parcelize functionality that will be a robust solution we can always use in the future.

And then we can properly unit test and abstract the Parcelize logic without having to rush to get it in

Also you can address this in the later PR too:

I realize after trying to help Greg with our /api routes,
we should probably add a simple example as a jsdoc string above all of our GET routes/requests

You can probably write one up really quick with ChatGPT or something,
should be pretty straightforward,
just ask it to write a jsdoc but give it the context on the search params and any caveats, etc, then tell it to write an example

@CRBl69
Copy link
Collaborator Author

CRBl69 commented Dec 2, 2024

Noting that all parcel changes were moved to #435 in order to merge this ASAP.

@CRBl69 CRBl69 added urgency-high Please check first size-medium A medium sized PR. This can be reviewed and merged in a moderate amount of time. size-small A small PR. This can be reviewed and merged fast. and removed size-medium A medium sized PR. This can be reviewed and merged in a moderate amount of time. labels Dec 2, 2024
@xbtmatt xbtmatt changed the title [ECO-2493] Market performance optimization [ECO-2493] Change chart to use quote volume Dec 2, 2024
@xbtmatt xbtmatt changed the title [ECO-2493] Change chart to use quote volume [ECO-2493] Change chart to use quote volume, set default visible range Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-small A small PR. This can be reviewed and merged fast. urgency-high Please check first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants