-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-2493] Change chart to use quote volume, set default visible range #409
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove unused fields from swap/chat events when fetching from the indexer (based on what the market page uses, it's like 4-5 fields total, you can get rid of most of the market state/periodic state event stuff)
- Cache the swap/chat data like we do with candlesticks
- Consolidate the safe number parsing logic into a single function with a try/catch that returns false if it throws an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed on eng call: split this PR up into two PRs where the first one is simply the more basic performance optimizations with infinite load, and the second is the generic, parameterizable Parcelize
functionality that will be a robust solution we can always use in the future.
And then we can properly unit test and abstract the Parcelize logic without having to rush to get it in
Also you can address this in the later PR too:
I realize after trying to help Greg with our /api routes,
we should probably add a simple example as a jsdoc string above all of our GET routes/requests
You can probably write one up really quick with ChatGPT or something,
should be pretty straightforward,
just ask it to write a jsdoc but give it the context on the search params and any caveats, etc, then tell it to write an example
Noting that all parcel changes were moved to #435 in order to merge this ASAP. |
Description
100
=>25
)