Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-2501] Fix the WSOD with Aptos Connect adapter on Firefox/Safari #417

Merged
merged 35 commits into from
Feb 3, 2025
Merged

[ECO-2501] Fix the WSOD with Aptos Connect adapter on Firefox/Safari #417

merged 35 commits into from
Feb 3, 2025

Conversation

xbtmatt
Copy link
Collaborator

@xbtmatt xbtmatt commented Nov 27, 2024 •
edited
Loading

Description

WSOD on Firefox/Safari when submitting txns. We need to unroll the wallet adapter transaction submission so there's no promises while the window tries to open a pop-up, or the browsers will say the application has crashed.

Testing

Manually with the preview build. Also we need to test on mobile, too.

  • Ensure it works on mobile on safari
  • Ensure all state is still loading from various events
  • Things should load in swap history
  • Check nearly everything on the site where you can submit
  • Ensure that any buttons that submit transactions are disabled while the builder is loading (if props change, it should temporarily be disabled while the builder finishes its async call)

Extra things fixed/changed during this process:

  • For anything but register market (anything that doesn't use the sign then submit flow), the transaction builder no longer makes async calls to the fullnode when building a transaction. The wallet adapter now handles it. This reduces the amount of API calls our frontend does and reduces the amount of time from click => transaction preview from ~150ms to ~5ms
  • Sequence number is now fetched on an interval/on demand, for the register market flow. This also reduces the fullnode queries and speeds it up in general, even for sign then submit flow

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you update the changelog?
  • Did you check all checkboxes from the linked Linear task?

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:54pm
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:54pm

@xbtmatt xbtmatt added urgency-low Can check after high/medium urgency size-small A small PR. This can be reviewed and merged fast. labels Dec 2, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@xbtmatt xbtmatt marked this pull request as ready for review February 1, 2025 00:50
xbtmatt added 23 commits February 3, 2025 13:52
@xbtmatt
Update the liquidity page to use the new flow
c0e2daa
@xbtmatt
Update the metadata page to use the new flow
f12dd8e
@xbtmatt
Update the swap button page to use the new flow
6f60f1c
@xbtmatt
Update the chat button to use the new flow
eb6a16d
@xbtmatt
Add the two transaction builder hooks
062d532
@xbtmatt
Add the register market flow with the different transaction builder a…
64fa20b 
…nd new account sequence number flow
@xbtmatt
Add server logs
94ff0ea
@xbtmatt
Fix prod check
be78566
@xbtmatt
Fix liquidity submission
58c22b8 
Add server logs
@xbtmatt
Remove unused imports
da75b0d
@xbtmatt
Format
bd1f079
@xbtmatt
Refactor liquidity page to use a hook to clean up the liquidity compo…
b6877e4 
…nent
@xbtmatt
Add coin types helper for submitting entry function type tags
b99c78b
@xbtmatt
Add transaction builders for each entry function to clean up visual c…
bfc2d6b 
…omponent code

Remove old hook locations

Refactor chat/swap/liquidity components to use the hooks
@xbtmatt
Rename builders to be brief
7f75493 
Incorporate the new hooks into the market metadata page and the market registration page
@xbtmatt
Format/lint
8d94a5d
@xbtmatt
Fix paths
752d7f3
@xbtmatt
Mark the sequence number as stale in the AptosContextProvider rather …
fde1465 
…than just in the register market flow
@xbtmatt
Dependency array fix
c7e266f
@xbtmatt
Fix the issue with FixedBytes and types, simplify things
0316eae
@xbtmatt
Fix the accidental import of the SDK package to the SDK itself
b24bc06
@xbtmatt
Fix the serialize args stuff and rename things
7c6040c
@xbtmatt
Lint/format
0d87760
@xbtmatt xbtmatt merged commit 092e28e into main Feb 3, 2025
7 checks passed
@xbtmatt xbtmatt deleted the ECO-2501 branch February 3, 2025 21:58
alnoki pushed a commit that referenced this pull request Feb 4, 2025
@xbtmatt @alnoki
[ECO-2501] Fix the WSOD with Aptos Connect adapter on Firefox/Safari (#…
fe04d41 
…417)
@alnoki alnoki mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRBl69 CRBl69 CRBl69 approved these changes

Assignees
No one assigned
Labels
size-big A big PR. This will take a while to be reviewed and merged. urgency-low Can check after high/medium urgency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xbtmatt @CRBl69