-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-2530] Fix emojis not showing up on most devices; add jest
setup for frontend
#433
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
i think its worth weighting whether its better to have a single canonical emoji image, that matches the FA uri, vs reducing the package size on devices with good native emoji fonts
i dont like the noto font, twitter's is far better noto doesn't have emojis for many code points, ive noticed missing skin tones, flags etc the noto US flag emoji looks like dogshit, as do many others. twemoji-15.0.3 font is open-source and much better https://emojipedia.org/twitter/twemoji-15.0.3 ![]() ![]() |
Remove font from table card styles
Description
This means all smart-contract supported emojis will show up on the website for everyone now!
The client will deliver a fairly large font package now, but it's worth it for non-Apple devices. Apple devices get special treatment because the Apple emoji font is gorgeous and obviously lightweight for those users.
layout.tsx
fileem-emoji
element since it's somewhat heavy and needlessly increases the overall DOM size since we use so many emojis everywherejest
setup for the frontend. Yay finally!Testing
- [ ] Ensure users don't download the font if they're on an iOS/Mac deviceThis is actually possible if we don't force a preload by including it in an element in the top
layout.tsx
, but it causes flashing on non-Apple devices, so it's better to include it and have NextJS preload the font.Checklist