This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
[ECO-2066] Add publisher and websocket indexer changes #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnoki
reviewed
Aug 7, 2024
There was a problem hiding this comment.
Previously I was fine with merging in something auxiliary to inbox, but that was when I was under the impression that there would just be an extra service. However this is deprecating MQTT, which the frontend currently relies on, taking out the TLS cert README, etc.
Basically these are breaking changes that will take down notifications on the frontend, if for example, we need to make a new inbox deployment, and since we are going to rebuild the indexer inside the emojicoin-dot-fun repo anyways, I think it might actually be best to leave this PR open essentially as a template, then close it once we've finished the indexer rebuild
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the processor WebSocket server and a new publisher program.