Add support of older versions of Doctrine/Dbal library #175

[tworzenieweb]

In order to provide wider support of this library for legacy projects, we should add support for legacy versions of doctrine/dbal library. In particular versions ^2.12.0|^3.0 have a bit different QueryBuilder methods available.

The other small changes are related to accessing the schema manager.

[tworzenieweb]

I got one concern for testing, locally I am able to shuffle the doctrine/dbal version between 2 and 3 by modifying the composer.json, but in CI/CD not sure how we could achieve that.

Actually while typing, found this lib:

https://github.com/kylekatarnls/multi-tester

[dgafka]

I got one concern for testing, locally I am able to shuffle the doctrine/dbal version between 2 and 3 by modifying the composer.json, but in CI/CD not sure how we could achieve that.

@tworzenieweb we are covered with this.
CI runs with prefer-lowest and prefer-stable, to ensure lowest and highest possible stable versions :)

[dgafka]

Can you fix the compatibility in main composer.json? This allows to run Monorepo tests with same range of versions as each package has :)

[dgafka]

Do we need to extend QueryBuilder? If they will put final on the class, this will break.

I am fine with Ecotone's abstraction which will hide the QueryBuilder inside :)

[tworzenieweb]

sadly there is no interface to implement to duck type, because some tests are creating QB instance and got a return type defined to be QueryBuilder from Doctrine/Dbal. We could of course change that if you like.

    private function getDocumentsFor(string $collectionName): \Doctrine\DBAL\Query\QueryBuilder
    {
        return (new QueryBuilderProxy($this->getConnection()->createQueryBuilder()))
            ->select('document', 'document_type')
            ->from($this->getTableName())
            ->andWhere('collection = :collection')
            ->setParameter('collection', $collectionName, Types::TEXT);
    }

[dgafka]

Ok, I see, let's keep it this way then.
I count on Dbal, that they will provide interface in case of making it final :)

[tworzenieweb]

When I think about it now, it might be also a nice starting point if doctrine/dbal 4.0 will ever be released.

[tworzenieweb]

I got one concern for testing, locally I am able to shuffle the doctrine/dbal version between 2 and 3 by modifying the composer.json, but in CI/CD not sure how we could achieve that.

@tworzenieweb we are covered with this. CI runs with prefer-lowest and prefer-stable, to ensure lowest and highest possible stable versions :)

nice, wasn't aware of that 👍

[dgafka]

Thanks for contribution :)

[marmichalski]

I got one concern for testing, locally I am able to shuffle the doctrine/dbal version between 2 and 3 by modifying the composer.json, but in CI/CD not sure how we could achieve that.

@tworzenieweb we are covered with this. CI runs with prefer-lowest and prefer-stable, to ensure lowest and highest possible stable versions :)

CI runs against 3.x only (lowest as 3.6.0 to be precise), becauseof dependency on doctrine-bundle in version 2.9. DoctrineBundle 2.9.0 requires dbal 3.6.0. 😎

[dgafka]

Thanks @marmichalski for taking a look on that :)

I've fixed that with #179