refactor: resolve interceptors parameter converters during build #212
Conversation
jlabedo
changed the title
| continue; | ||
| } elseif ($parameter->getTypeDescriptor()->isNonCollectionArray()) { | ||
| $builtConverters[] = AllHeadersBuilder::createWith($parameter->getName())->build($referenceSearchService); | ||
| continue; |
There was a problem hiding this comment.
This will simplify the code, yet the performance will stay the same, as build method is executed on run time.
Whatever has ReferenceSearchService $referenceSearchService, means it has to work booted container.
There was a problem hiding this comment.
or maybe it will help, if given class is executed more than once. As we will then reuse constructed parameters
There was a problem hiding this comment.
Are you planning to create parameter converter builder during the object construction as follow up?
There was a problem hiding this comment.
Yes I know :) the plan is to do all this work before something is serialized for caching, but I am not sure at that time of how to do it. My goal is to try something wich would work with incremental refactorings to demonstrate the performance gain.
And whatever you cache, the core messaging components should have low construction cost to show the performance boost.
No description provided.