Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly use bash shell in PR stats workflow #225

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

marmichalski
Copy link
Contributor

@marmichalski marmichalski commented Oct 5, 2023

Checking if what I am saying is true, presumably closes #224.

@dgafka
Copy link
Member

dgafka commented Oct 6, 2023

Benchmark was already fixed, so we would need to commit some failure to PlaceOrderBenchmark to test it out :)

@marmichalski marmichalski marked this pull request as ready for review October 6, 2023 09:25
@marmichalski
Copy link
Contributor Author

This has indeed been confirmed to be a fix.

More can be read here: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell

@dgafka dgafka merged commit afedb4a into ecotoneframework:main Oct 6, 2023
18 checks passed
@dgafka
Copy link
Member

dgafka commented Oct 6, 2023

🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When benchmarks fails, then workflow should fail
2 participants