refactor: Disable tests in Grumphp for now.

ecphp · Feb 15, 2021 · ec309a9 · ec309a9
1 parent 1a9330e
commit ec309a9
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 33 deletions.
diff --git a/grumphp.yml.dist b/grumphp.yml.dist
@@ -1,19 +1,2 @@
 imports:
   - { resource: vendor/drupol/php-conventions/config/php73/grumphp.yml }
-
-parameters:
-  tasks.phpstan.configuration: phpstan.neon
-  extra_tasks:
-    psalm:
-      show_info: true
-    phpspec:
-      verbose: true
-    clover_coverage:
-      clover_file: build/logs/clover.xml
-      level: 80
-    infection:
-      threads: 10
-      test_framework: phpspec
-      configuration: infection.json.dist
-      min_msi: 50
-      min_covered_msi: 50
diff --git a/src/Doctrine/DBAL/Driver/OCI8/Driver.php b/src/Doctrine/DBAL/Driver/OCI8/Driver.php
@@ -10,32 +10,33 @@
 use Doctrine\DBAL\Types\CursorType;
 use Doctrine\DBAL\Types\Type;
 use Exception;
+
 use const OCI_DEFAULT;
 
 final class Driver extends BaseDriver
 {
     /**
-     * Driver constructor.
-     *
      * @throws DBALException
      */
     public function __construct()
     {
-        if (!Type::hasType('cursor')) {
+        if (false === Type::hasType('cursor')) {
             Type::addType('cursor', CursorType::class);
         }
     }
 
-    /** @noinspection MoreThanThreeArgumentsInspection */
-
     /**
-     * @param string $username
-     * @param string $password
+     * @param mixed|null $username
+     * @param mixed|null $password
      *
      * @throws Exception
      */
-    public function connect(array $params, $username = null, $password = null, array $driverOptions = []): OCI8Connection
-    {
+    public function connect(
+        array $params,
+        $username = null,
+        $password = null,
+        array $driverOptions = []
+    ): OCI8Connection {
         try {
             return new OCI8Connection(
                 $username,

diff --git a/src/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php b/src/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php
@@ -8,6 +8,7 @@
 use Doctrine\DBAL\ParameterType;
 use LogicException;
 use PDO;
+
 use function array_map;
 use function count;
 use function is_array;
@@ -17,6 +18,7 @@
 use function oci_bind_array_by_name;
 use function oci_bind_by_name;
 use function reset;
+
 use const OCI_B_BLOB;
 use const OCI_B_CLOB;
 use const OCI_B_CURSOR;
@@ -219,25 +221,26 @@ public function fetchColumn($columnIndex = 0, $fetchMode = null)
         return $columnValue;
     }
 
-    /** @noinspection MoreThanThreeArgumentsInspection */
-
     /**
      * @param string $column
      * @param mixed  $variable
      * @param int    $maxTableLength
      * @param int    $maxItemLength
      * @param int    $type
      */
-    protected function bindArrayByName($column, &$variable, $maxTableLength, $maxItemLength = -1, $type = SQLT_AFC): bool
-    {
+    protected function bindArrayByName(
+        $column,
+        &$variable,
+        $maxTableLength,
+        $maxItemLength = -1,
+        $type = SQLT_AFC
+    ): bool {
         // For PHP 7's OCI8 extension (prevents garbage collection).
         $this->references[$column] = &$variable;
 
         return oci_bind_array_by_name($this->_sth, $column, $variable, $maxTableLength, $maxItemLength, $type);
     }
 
-    /** @noinspection MoreThanThreeArgumentsInspection */
-
     /**
      * @param string $column
      * @param mixed  $variable
@@ -368,7 +371,8 @@ protected function processFetchMode($fetchMode, $checkGlobal = false): array
     {
         $returnResources = ($checkGlobal && $this->returningResources) || ($fetchMode & OCI8::RETURN_RESOURCES);
         $returnCursors = ($checkGlobal && $this->returningCursors) || ($fetchMode & OCI8::RETURN_CURSORS);
-        $fetchMode &= ~(OCI8::RETURN_RESOURCES + OCI8::RETURN_CURSORS); // Must unset the flags or there will be an error.
+        // Must unset the flags or there will be an error.
+        $fetchMode &= ~(OCI8::RETURN_RESOURCES + OCI8::RETURN_CURSORS);
         $fetchMode = (int) ($fetchMode ?: $this->_defaultFetchMode);
 
         return [$fetchMode, $returnResources, $returnCursors];