Skip to content

fixed mpi processes not terminating #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Stage zero files generation
merged 1 commit into from
Oct 6, 2025
Merged

fixed mpi processes not terminating #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/data-generators/concrete/StageZeroGeneratorParsec.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ template<typename T>
StageZeroGeneratorParsec<T> *StageZeroGeneratorParsec<T>::GetInstance() {
if (mpInstance == nullptr) {
// Ensure MPI is initialized before creating the instance
int initialized;
MPI_Initialized(&initialized);
if (!initialized) {
int argc = 0;
char **argv = nullptr;
MPI_Init(&argc, &argv);
}
// int initialized;
// MPI_Initialized(&initialized);
// if (!initialized) {
// int argc = 0;
// char **argv = nullptr;
// MPI_Init(&argc, &argv);
// }
mpInstance = new StageZeroGeneratorParsec<T>();
}
return mpInstance;
Expand All @@ -76,11 +76,25 @@ void StageZeroGeneratorParsec<T>::ReleaseInstance() {

template<typename T>
void StageZeroGeneratorParsec<T>::Runner(exageostat::configurations::Configurations &aConfigurations) {
int rank, nprocs;
MPI_Comm_rank(MPI_COMM_WORLD, &rank);
MPI_Comm_size(MPI_COMM_WORLD, &nprocs);

mArgs.mConfigs = &aConfigurations;
this->ConfigureGenerator();
this->Allocate();
this->ReadForcingData();
this->ReadNetCDFFiles();

// After data gathering, only rank 0 continues with optimization
// Other ranks can exit since they're no longer needed
if (rank != 0) {
fprintf(stderr, "[StageZero PaRSEC] Rank %d: Data gathering complete, exiting (only rank 0 performs optimization)\n", rank);
this->CleanUp();
return;
}

fprintf(stderr, "[StageZero PaRSEC] Rank 0: Starting optimization phase\n");
this->RunMeanTrend();

this->CleanUp();
Expand Down