fix: avoid ticking on default object

ecsact-dev · Aug 16, 2024 · e45cb47 · e45cb47
1 parent 1e1ed08
commit e45cb47
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 20 deletions.
diff --git a/Source/Ecsact/Private/Ecsact.cpp b/Source/Ecsact/Private/Ecsact.cpp
@@ -123,24 +123,23 @@ auto FEcsactModule::StartRunner() -> void {
 		StopRunner();
 	}
 
-	// switch(settings->Runner) {
-	// 	case EEcsactRuntimeRunnerType::Automatic:
-	// 		if(ecsact_async_flush_events == nullptr) {
-	// 			Runner = NewObject<UEcsactSyncRunner>();
-	// 		} else {
-	// 			Runner = NewObject<UEcsactAsyncRunner>();
-	// 		}
-	// 		break;
-	// 	case EEcsactRuntimeRunnerType::Asynchronous:
-	// 		Runner = NewObject<UEcsactAsyncRunner>();
-	// 		break;
-	// 	case EEcsactRuntimeRunnerType::Custom:
-	// 		if(settings->CustomRunnerClass != nullptr) {
-	// 			Runner = NewObject<UEcsactRunner>(nullptr,
-	// settings->CustomRunnerClass);
-	// 		}
-	// 		break;
-	// }
+	switch(settings->Runner) {
+		case EEcsactRuntimeRunnerType::Automatic:
+			if(ecsact_async_flush_events == nullptr) {
+				Runner = NewObject<UEcsactSyncRunner>();
+			} else {
+				Runner = NewObject<UEcsactAsyncRunner>();
+			}
+			break;
+		case EEcsactRuntimeRunnerType::Asynchronous:
+			Runner = NewObject<UEcsactAsyncRunner>();
+			break;
+		case EEcsactRuntimeRunnerType::Custom:
+			if(settings->CustomRunnerClass != nullptr) {
+				Runner = NewObject<UEcsactRunner>(nullptr, settings->CustomRunnerClass);
+			}
+			break;
+	}
 
 	if(Runner != nullptr) {
 		UE_LOG(

diff --git a/Source/Ecsact/Public/EcsactAsyncRunner.cpp b/Source/Ecsact/Public/EcsactAsyncRunner.cpp
@@ -5,7 +5,6 @@
 #include "ecsact/runtime/common.h"
 
 auto UEcsactAsyncRunner::Tick(float DeltaTime) -> void {
-	UE_LOG(Ecsact, Log, TEXT("ASYNC RUNNER TICK()"));
 	if(ecsact_async_flush_events == nullptr) {
 		UE_LOG(Ecsact, Error, TEXT("ecsact_async_flush_events is unavailable"));
 	} else {

diff --git a/Source/Ecsact/Public/EcsactRunner.cpp b/Source/Ecsact/Public/EcsactRunner.cpp
@@ -6,3 +6,7 @@ auto UEcsactRunner::Tick(float DeltaTime) -> void {
 auto UEcsactRunner::GetStatId() const -> TStatId {
 	RETURN_QUICK_DECLARE_CYCLE_STAT(UEcsactRunner, STATGROUP_Tickables);
 }
+
+auto UEcsactRunner::IsTickable() const -> bool {
+	return !IsTemplate();
+}
diff --git a/Source/Ecsact/Public/EcsactRunner.h b/Source/Ecsact/Public/EcsactRunner.h
@@ -12,4 +12,5 @@ class UEcsactRunner : public UObject, public FTickableGameObject {
 public:
 	auto Tick(float DeltaTime) -> void override;
 	auto GetStatId() const -> TStatId override;
+	auto IsTickable() const -> bool override;
 };
diff --git a/Source/Ecsact/Public/EcsactSyncRunner.cpp b/Source/Ecsact/Public/EcsactSyncRunner.cpp
@@ -4,7 +4,6 @@
 #include "ecsact/runtime/core.h"
 
 auto UEcsactSyncRunner::Tick(float DeltaTime) -> void {
-	UE_LOG(Ecsact, Log, TEXT("SYNC RUNNER TICK()"));
 	if(ecsact_execute_systems == nullptr) {
 		UE_LOG(Ecsact, Error, TEXT("ecsact_execute_systems is unavailable"));
 		return;