firebase: refactor the refactoring #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const char* method, const String& path, | ||
| const String& data, HTTPClient* http) { | ||
| if (!http) { | ||
| http = &http_; |
There was a problem hiding this comment.
Always creating a HttpClient to only sometimes use seems wasteful but not a big deal I will fix this up down the road.
ed7coyne
added a commit
that referenced
this pull request
Jan 28, 2016
firebase: refactor the refactoring
ed7coyne
pushed a commit
that referenced
this pull request
Feb 23, 2016
Firebase: update arduino core define
ed7coyne
pushed a commit
that referenced
this pull request
Apr 15, 2016
hardware/FireboyYun: bump revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in FirebaseExtended#42
Stream example won't compile because of esp8266/Arduino#500