Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch googletest in the lib directory #42

Merged
merged 14 commits into from
Jun 11, 2024

Conversation

navidcity
Copy link
Collaborator

New Features

  • None

Changes

  • None

Bug Fixes

  • The lib/googletest directory is added to the Cpp/googletest example

Related PRs:

  • None

@navidcity navidcity requested a review from Paebbels June 11, 2024 20:19
@navidcity navidcity self-assigned this Jun 11, 2024
@Paebbels Paebbels changed the base branch from main to dev June 11, 2024 20:21
Copy link
Member

@Paebbels Paebbels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline.yml needs adjustments.

FetchContent_Declare(
googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG f8d7d77c06936315286eb55f8de22cd23c188571 # release-1.14.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does CMake support symbolic refs like tags instead of heavy hashes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do mean by heavy hash?

@Paebbels Paebbels added the Unit Testing Unit test summaries label Jun 11, 2024
@Paebbels Paebbels merged commit 570b328 into edaa-org:dev Jun 11, 2024
2 checks passed
@Paebbels Paebbels mentioned this pull request Jun 11, 2024
@navidcity navidcity deleted the fix/googletest_example branch June 11, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unit Testing Unit test summaries
Development

Successfully merging this pull request may close these issues.

2 participants