-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auxiliary dataframe #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19ddf05
to
a39c79b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
juntyr
reviewed
Jun 25, 2023
juntyr
reviewed
Jun 25, 2023
54bd117
to
cb2b716
Compare
cb2b716
to
c61a47c
Compare
juntyr
reviewed
Jul 4, 2023
juntyr
reviewed
Jul 4, 2023
juntyr
reviewed
Jul 4, 2023
juntyr
reviewed
Jul 4, 2023
juntyr
reviewed
Jul 4, 2023
@Aggrathon I think you missed some validations, though it might also have been me. Apart from the tiny nit I found, it otherwise looks good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed earlier. It would be nice if all "new columns" (such as embeddings) where part of an "auxiliary" dataframe, since then all new/old plots could automatically use all new/old columns. This PR creates a new dataframe that currently can contain the PCA embedding (computed by xiplot), clusters (computed by xiplot), and selected points. All old plots are updated to handle this new behaviour.
Things to note: