Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auxiliary dataframe #38

Merged
merged 28 commits into from
Jul 4, 2023
Merged

Auxiliary dataframe #38

merged 28 commits into from
Jul 4, 2023

Conversation

Aggrathon
Copy link
Member

As we discussed earlier. It would be nice if all "new columns" (such as embeddings) where part of an "auxiliary" dataframe, since then all new/old plots could automatically use all new/old columns. This PR creates a new dataframe that currently can contain the PCA embedding (computed by xiplot), clusters (computed by xiplot), and selected points. All old plots are updated to handle this new behaviour.

Things to note:

  • The auxiliary dataframe is not stored server side (that requires that we update dash_extensions).
  • There are new classes for column selection and cluster selection dropdowns (that include easy regex).
  • I've tested this in WASM and it seems to be working.
  • So much has happened in the repo, so I bumped the version (xiplot should at some point be updated on PyPi as well).

@Aggrathon Aggrathon force-pushed the auxiliary-dataframe branch from 19ddf05 to a39c79b Compare June 16, 2023 15:08
@Aggrathon Aggrathon requested a review from TanakaAkihiro June 21, 2023 12:17
Copy link
Collaborator

@TanakaAkihiro TanakaAkihiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Aggrathon Aggrathon force-pushed the auxiliary-dataframe branch 5 times, most recently from 54bd117 to cb2b716 Compare July 3, 2023 14:06
@Aggrathon Aggrathon force-pushed the auxiliary-dataframe branch from cb2b716 to c61a47c Compare July 3, 2023 14:20
@Aggrathon Aggrathon requested a review from juntyr July 3, 2023 14:32
@juntyr
Copy link
Collaborator

juntyr commented Jul 4, 2023

@Aggrathon I think you missed some validations, though it might also have been me. Apart from the tiny nit I found, it otherwise looks good to me :)

@Aggrathon Aggrathon merged commit 7933d4b into main Jul 4, 2023
@Aggrathon Aggrathon deleted the auxiliary-dataframe branch July 5, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants