Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set numpy version, bump release #192

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Set numpy version, bump release #192

merged 3 commits into from
Jun 25, 2024

Conversation

edbeeching
Copy link
Owner

Should fix issue #191

@edbeeching edbeeching requested a review from Ivan-267 June 25, 2024 15:05
Ivan-267
Ivan-267 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@Ivan-267 Ivan-267 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The windows fix seems right. Not sure about the other errors yet, we may need to check those too.

@Ivan-267
Update ray_wrapper.py
2bd6139 
Updates local_dir to storage_path
@Ivan-267
Copy link
Collaborator

All tests seem to pass now. I added the small change for Rllib that the error message suggested.

@edbeeching edbeeching merged commit d1ecffe into main Jun 25, 2024
13 checks passed
@edbeeching edbeeching deleted the fix-numpy branch June 25, 2024 18:48
@Ivan-267 Ivan-267 mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivan-267 Ivan-267 Ivan-267 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edbeeching @Ivan-267