Fix function name #210
Merged
Fix function name #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan-267
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Thanks for spotting this! I just used imitation learning, but didn't notice this as my local branch already has this change applied, it seems I forgot to make a PR with this.
I did rename the method since we can export when using SAC too (and with a small change to the code that detects the type, TRPO, likely A2C, and possibly some others).
edbeeching
approved these changes
Nov 4, 2024
|
Feel free to merge. I don't have write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this function was renamed.