Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select dropdown with [isSearchable]=true not closing when caret is clicked. #118

Closed
jmozqueda1 opened this issue Jun 20, 2017 · 4 comments
Closed

Select dropdown with [isSearchable]=true not closing when caret is clicked. #118

jmozqueda1 opened this issue Jun 20, 2017 · 4 comments
Assignees
@edcarroll
Labels
comp: select priority: low type: bug
Milestone
0.8.4

Comments

@jmozqueda1
Copy link

Bug description:

Not able to close a sui-select or sui-multi-select when the [isSearchable]=true. My thinking was that I should be able to click on the caret for the dropdown to collapse instead of having to click on another part of the page since there could be additional items that would be hiding behind the dropdown. This can be recreated with the current demo.

Version of ng2-semantic-ui:

ng2-semantic-ui: 0.8.3
@edcarroll edcarroll added this to the 0.9.0 milestone Jun 20, 2017
@edcarroll
Copy link
Owner

edcarroll commented Jun 20, 2017 •
edited
Loading

Hi there, good catch, and I can see what you mean. Will add a fix to make clicking the caret close all selects to the next release :)

@jmozqueda1
Copy link
Author

Awesome. Thank you!

@edcarroll edcarroll self-assigned this Jun 20, 2017
@edcarroll edcarroll modified the milestones: 0.8.4, 0.9.0 Jun 21, 2017
edcarroll added a commit that referenced this issue Jun 21, 2017
@edcarroll
fix(select): Selects now close regardless of searchability when caret…
94302d3 
… clicked

Closes #118
@edcarroll edcarroll mentioned this issue Jun 21, 2017
Merged
edcarroll added a commit that referenced this issue Jun 21, 2017
@edcarroll
fix(select): Selects now close regardless of searchability when caret…
2ab2926 
… clicked

Closes #118
@edcarroll
Copy link
Owner

A fix for this is now live in 0.8.4 😄

@jmozqueda1
Copy link
Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edcarroll edcarroll

Labels
comp: select priority: low type: bug
Projects
None yet
Milestone
0.8.4
Development

No branches or pull requests
2 participants
@edcarroll @jmozqueda1