feat(datepicker) Popup now honors locale and pickerLocaleOverrides #215

harogaston · 2017-08-06T02:18:35Z

Datepicker popup items now respect locale format
Fixed a bug in zoom calendar mapping for datetime datepicker
Fixed 'es' locale for consistency

(*) Partially addresses #164

Before submitting a pull request, please make sure you have at least performed the following:

read and followed the CONTRIBUTING.md guide.
linted, built and tested the changes locally.
added/updated any applicable API documentation.
added/updated any applicable demos.

- Datepicker popup items now respect locale format - Fixed a bug in zoom calendar mapping for datetime datepicker - Fixed 'es' locale for consistency (*) Partially addresses edcarroll#164

edcarroll · 2017-08-08T18:49:30Z

Thank you for the PR 🎉 will get this looked at properly tomorrow 😄

edcarroll

Looks good, couple of very minor points

edcarroll · 2017-08-10T16:35:36Z

src/behaviors/localization/locales/es.ts

@@ -24,7 +24,7 @@ const es:IPartialLocaleValues = {
        ],
        formats: {
            time: "HH:mm",
-            datetime: "D MMMM [de] YYYY HH:mm",
+            datetime: "D [de] MMMM [de] YYYY HH:mm",


@genuinefafa is this correct?

@harogaston I know you live in Uruguay just want to check all the same!

Yes, I am sure. Further reference here (in Spanish sorry) The website belongs to the Spanish Royal Academy. Which is the authority that legislates the language (yes, we are cool as that :P).

Great! All good then 😄

as @harogaston said, we - the ones from the Río de la Plata - know better (?).

edcarroll · 2017-08-10T16:36:56Z

src/modules/datepicker/classes/calendar-mappings.ts

@@ -69,7 +69,7 @@ export class DatetimeMappings extends CalendarMappings {
            [CalendarViewType.Month, CalendarViewType.Year],
            [CalendarViewType.Date, CalendarViewType.Month],
            [CalendarViewType.Hour, CalendarViewType.Date],
-            [CalendarViewType.Minute, CalendarViewType.Date]
+            [CalendarViewType.Minute, CalendarViewType.Hour]


This was on purpose as it is the behaviour of the original module

Ok then. For me it felt like a bug, meaning odd behavior.

Fairs, @mcosta74 what are your thoughts on this behaviour?

I'll wait for this to be decided on, before I send the PR.

Points in favor of the proposed change:

"zoomOut" shouldn't skip a step

If user wants to change hour, will be forced to re-select date

Points against the proposed change:

After a date is selected, two clicks are needed to get to the date view (if on datetime mode)

Actually, let's keep this change. Because, in the Calendar module (that this is based on) the left right arrows go across days when looking at minutes, which fits the old behavior. However, the datepicker allows navigation across hours, so it's inconsistent now.

edcarroll · 2017-08-10T16:59:25Z

src/modules/datepicker/views/hour-view.ts

 import { CalendarView, CalendarViewType } from "./calendar-view";
 import { CalendarItem } from "../directives/calendar-item";
 import { CalendarRangeService } from "../services/calendar-range.service";
 import { DateParser } from "../classes/date-parser";

 export class CalendarRangeHourService extends CalendarRangeService {
    public configureItem(item:CalendarItem, baseDate:Date):void {
-        item.humanReadable = `${Util.String.padLeft(item.date.getHours().toString(), 2, "0")}:00`;
+        const customFormat:string = this.service.localeValues.formats.time.replace(/m/g, "0");


Please add a comment saying what this does for future clarity (took me a minute to get it!)

edcarroll · 2017-08-10T17:00:51Z

src/modules/datepicker/views/minute-view.ts

+            const dateTimeFormat:string = this.service.localeValues.formats.datetime.replace(/m/g, "0");
+            return new DateParser(dateTimeFormat, this.service.localeValues).format(this.currentDate);
+        } else {
+            const timeFormat:string = this.service.localeValues.formats.time.replace(/m/g, "0");


As above, add a quick explanation here

* fix: Fixed AOT on SystemJS builder Closes #209 * fix: Added custom FocusEvent interface (#231) * fix: Added custom FocusEvent interface Closes #202 FocusEvent isn't defined in UC browser, so added IFocusEvent with the property we need. * style(util): Fixed tslint error * chore(popup): Relaxed popper.js dependency (#228) Follows up on #195 * fix(popup): Fixed delay causing destroyed view errors (#233) Closes #189 * fix(select): Manually run change detector when option updates (#236) * fix(select): Manually run change detector when option updates Closes #213 * style(select): Fixed tslint error * fix(select): Selected options now updated when options change (#232) * fix(modal): Fixed aggressive autofocus sometimes causing errors (#237) * fix(popup): Fixed conflict with BrowserAnimationsModule (#234) * fix(popup): Fixed conflict with BrowserAnimationsModule Closes #204 * style(popup): Fixed tslint error * feat(popup): Added template context support (#238) * fix(popup): Fixed focus events on popup (#243) * feat(datepicker) Popup now honors locale and pickerLocaleOverrides (#215) * Datepicker popup now honors locale and pickerLocaleOverrides - Datepicker popup items now respect locale format - Fixed a bug in zoom calendar mapping for datetime datepicker - Fixed 'es' locale for consistency (*) Partially addresses #164 * Added comments. * Time of day values supported in locale definitions (#214) * en-GB and en-US locales now use 12 hour format Original "HH:mm" (23:59) -> Now "hh:mm aa" (11:59 p.m.) * Fix locales Russian, Italian and Hebrew now extend from ILocaleValues. * Added new IDatepickerFormatsLocaleValues fields: - timesOfDay - timesOfDayUppercase - timesOfDayLowercase to support proper formatting/parsing of dates in datepicker. Updated Localization page * Fixing code formatting * feat(datepicker) Added initial date support for the datepicker (#216) * feat(datepicker) New input pickerInitialDate - New input (optional) that sets the intial date to display (null = today) - Updated demo page Partially addresses #165 * Now pickerInitialDate only sets CalendarService.currentDate property * feat(datepicker): Initial date support - Code formatting * fix: Various minor bugfixes (#245) * fix(select): Fixed destroyed view errors * fix(modal): Fix modal auto closing when clicked * fix(popup): Removed console log in focus handler * fix(popup): Forced import of TemplateRef * fix: Fixed AOT on SystemJS builder Closes #209

…dcarroll#215) * Datepicker popup now honors locale and pickerLocaleOverrides - Datepicker popup items now respect locale format - Fixed a bug in zoom calendar mapping for datetime datepicker - Fixed 'es' locale for consistency (*) Partially addresses edcarroll#164 * Added comments.

* fix: Fixed AOT on SystemJS builder Closes edcarroll#209 * fix: Added custom FocusEvent interface (edcarroll#231) * fix: Added custom FocusEvent interface Closes edcarroll#202 FocusEvent isn't defined in UC browser, so added IFocusEvent with the property we need. * style(util): Fixed tslint error * chore(popup): Relaxed popper.js dependency (edcarroll#228) Follows up on edcarroll#195 * fix(popup): Fixed delay causing destroyed view errors (edcarroll#233) Closes edcarroll#189 * fix(select): Manually run change detector when option updates (edcarroll#236) * fix(select): Manually run change detector when option updates Closes edcarroll#213 * style(select): Fixed tslint error * fix(select): Selected options now updated when options change (edcarroll#232) * fix(modal): Fixed aggressive autofocus sometimes causing errors (edcarroll#237) * fix(popup): Fixed conflict with BrowserAnimationsModule (edcarroll#234) * fix(popup): Fixed conflict with BrowserAnimationsModule Closes edcarroll#204 * style(popup): Fixed tslint error * feat(popup): Added template context support (edcarroll#238) * fix(popup): Fixed focus events on popup (edcarroll#243) * feat(datepicker) Popup now honors locale and pickerLocaleOverrides (edcarroll#215) * Datepicker popup now honors locale and pickerLocaleOverrides - Datepicker popup items now respect locale format - Fixed a bug in zoom calendar mapping for datetime datepicker - Fixed 'es' locale for consistency (*) Partially addresses edcarroll#164 * Added comments. * Time of day values supported in locale definitions (edcarroll#214) * en-GB and en-US locales now use 12 hour format Original "HH:mm" (23:59) -> Now "hh:mm aa" (11:59 p.m.) * Fix locales Russian, Italian and Hebrew now extend from ILocaleValues. * Added new IDatepickerFormatsLocaleValues fields: - timesOfDay - timesOfDayUppercase - timesOfDayLowercase to support proper formatting/parsing of dates in datepicker. Updated Localization page * Fixing code formatting * feat(datepicker) Added initial date support for the datepicker (edcarroll#216) * feat(datepicker) New input pickerInitialDate - New input (optional) that sets the intial date to display (null = today) - Updated demo page Partially addresses edcarroll#165 * Now pickerInitialDate only sets CalendarService.currentDate property * feat(datepicker): Initial date support - Code formatting * fix: Various minor bugfixes (edcarroll#245) * fix(select): Fixed destroyed view errors * fix(modal): Fix modal auto closing when clicked * fix(popup): Removed console log in focus handler * fix(popup): Forced import of TemplateRef * fix: Fixed AOT on SystemJS builder Closes edcarroll#209

Datepicker popup now honors locale and pickerLocaleOverrides

65fd413

- Datepicker popup items now respect locale format - Fixed a bug in zoom calendar mapping for datetime datepicker - Fixed 'es' locale for consistency (*) Partially addresses edcarroll#164

edcarroll requested changes Aug 10, 2017

View reviewed changes

edcarroll modified the milestone: 0.9.5 Aug 11, 2017

edcarroll added state: wip and removed state: wip labels Aug 11, 2017

Added comments.

6b6bd82

harogaston changed the title ~~Datepicker popup now honors locale and pickerLocaleOverrides~~ feat(datepicker) Popup now honors locale and pickerLocaleOverrides Aug 13, 2017

harogaston mentioned this pull request Aug 13, 2017

en-GB and en-US locales now use 12 hour format #214

Merged

4 tasks

edcarroll approved these changes Aug 13, 2017

View reviewed changes

edcarroll merged commit c0158b3 into edcarroll:master Aug 13, 2017

harogaston deleted the 12-hour-time-selection branch August 13, 2017 02:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(datepicker) Popup now honors locale and pickerLocaleOverrides #215

feat(datepicker) Popup now honors locale and pickerLocaleOverrides #215

harogaston commented Aug 6, 2017

edcarroll commented Aug 8, 2017

edcarroll left a comment

edcarroll Aug 10, 2017

edcarroll Aug 10, 2017

harogaston Aug 11, 2017

edcarroll Aug 11, 2017

genuinefafa Aug 22, 2017

edcarroll Aug 10, 2017

harogaston Aug 11, 2017

edcarroll Aug 11, 2017

harogaston Aug 12, 2017 •

edited

Loading

edcarroll Aug 13, 2017

edcarroll Aug 10, 2017

harogaston Aug 11, 2017

edcarroll Aug 10, 2017

harogaston Aug 11, 2017

feat(datepicker) Popup now honors locale and pickerLocaleOverrides #215

feat(datepicker) Popup now honors locale and pickerLocaleOverrides #215

Conversation

harogaston commented Aug 6, 2017

edcarroll commented Aug 8, 2017

edcarroll left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harogaston Aug 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harogaston Aug 12, 2017 •

edited

Loading