Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selective add files to generate to improve performance #326

Merged
merged 10 commits into from
Aug 20, 2024
Merged

Selective add files to generate to improve performance #326

merged 10 commits into from
Aug 20, 2024

Conversation

eddeee888
Copy link
Owner

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a7fa7e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eddeee888/gcg-typescript-resolver-files Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eddeee888
Copy link
Owner Author

/release-snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

✅ Successfully published package/s with tag pr326-run591-1!

@eddeee888
Copy link
Owner Author

/release-snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

✅ Successfully published package/s with tag pr326-run592-1!

@eddeee888
Copy link
Owner Author

/release-snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

✅ Successfully published package/s with tag pr326-run593-1!

@eddeee888 eddeee888 force-pushed the selective-add-generates branch from 0afb64a to 8e5a7b7 Compare August 2, 2024 16:50
@eddeee888
Copy link
Owner Author

/release-snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

✅ Successfully published package/s with tag pr326-run594-1!

@eddeee888
Copy link
Owner Author

/release-snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

✅ Successfully published package/s with tag pr326-run595-1!

@eddeee888 eddeee888 force-pushed the selective-add-generates branch from 84049cf to cb292cb Compare August 2, 2024 17:19
@eddeee888
Copy link
Owner Author

/release-snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

✅ Successfully published package/s with tag pr326-run596-1!

eddeee888
eddeee888 commented Aug 7, 2024
View reviewed changes
...resolver-files-e2e/src/test-resolvers-auto-wireup/schema/base/resolvers/CustomLogicScalar.ts
Comment on lines +1 to +6
import { DateResolver} from 'graphql-scalars'
DateResolver.description = undefined;
export const CustomLogicScalar = DateResolver;

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are changed because:

  • What we are seeing here is the un-formatted version by the setup
  • It means the files are not "tracked" by codegen and not run prettier on because of codegen's hooks
  • This is expected

@eddeee888 eddeee888 force-pushed the selective-add-generates branch from cb292cb to bb4c1cb Compare August 7, 2024 11:46
@eddeee888
Copy link
Owner Author

/release-snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

✅ Successfully published package/s with tag pr326-run597-1!

@eddeee888 eddeee888 force-pushed the selective-add-generates branch from 600356f to a7fa7e6 Compare August 7, 2024 12:57
@eddeee888 eddeee888 mentioned this pull request Aug 7, 2024
Closed
@eddeee888 eddeee888 changed the base branch from master to master-next August 20, 2024 11:38
@eddeee888 eddeee888 merged commit 3596279 into master-next Aug 20, 2024
13 checks passed
@eddeee888 eddeee888 deleted the selective-add-generates branch August 20, 2024 11:39
@eddeee888 eddeee888 mentioned this pull request Aug 20, 2024
Merged
eddeee888 added a commit that referenced this pull request Oct 28, 2024
@eddeee888
Selective add files to generate to improve performance (#326)
75079f3
eddeee888 added a commit that referenced this pull request Oct 30, 2024
@eddeee888
v0.11.0 (#329)
9b45bf3 
* Selective add files to generate to improve performance (#326)

* Use meta to handle federation __resolveReference better (#330)

* Remove legacy warning (#335)

* bump latest typescript-resolvers version (#337)

* Add changeset (#338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eddeee888