Skip to content

Commit

Permalink
Rollup merge of rust-lang#32271 - frewsxcv:compiletest-ignored-help-n…
Browse files Browse the repository at this point in the history
…ote, r=nikomatsakis

Add comment about opt-in nature of compiletest note/help messages.

The opt-in functionality was proposed and discussed in
rust-lang#21195
  • Loading branch information
eddyb committed Mar 19, 2016
2 parents 8be1d7d + 6ed7846 commit e28a1b6
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/compiletest/runtest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1025,6 +1025,10 @@ fn check_expected_errors(revision: Option<&str>,
expected.replace(r"\", "/")
}).collect::<Vec<String>>();

// If the testcase being checked contains at least one expected "help"
// message, then we'll ensure that all "help" messages are expected.
// Otherwise, all "help" messages reported by the compiler will be ignored.
// This logic also applies to "note" messages.
let (expect_help, expect_note) =
expected_errors.iter()
.fold((false, false),
Expand Down

0 comments on commit e28a1b6

Please sign in to comment.