feat: add kops 1.25 support #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
|
cc @argoyle any chance you would give a try to an alpha version ? |
|
Would be happy to do that 😄 |
Fixing a little issue with codegen ( |
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
|
@argoyle forgot to post, |
|
Got the notification from Github, will test during the day and get back to you. |
|
Seems to work fine. Created a cluster using the last non-alpha-release and K8S 1.24.5, upgrade to the alpha-release went fine and another upgrade to K8S 1.25.0 is rolling as we speak and seems to work fine as well. |
|
Thank you so much for taking the time to test it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support kOps 1.25