Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKACAT_VERSION not defined outside of git repo #92

Closed
edenhill opened this issue Mar 10, 2017 · 0 comments
Closed

KAFKACAT_VERSION not defined outside of git repo #92

edenhill opened this issue Mar 10, 2017 · 0 comments

Comments

@edenhill
Copy link
Owner

edenhill commented Mar 10, 2017 •
edited
Loading

Such as for homebrew builds:

kafkacat - Apache Kafka producer and consumer tool
https://github.com/edenhill/kafkacat
Copyright (c) 2014-2015, Magnus Edenhill
Version KAFKACAT_VERSION (librdkafka 0.9.4)
xvrl added a commit to xvrl/homebrew-core that referenced this issue Apr 4, 2017
@xvrl
kafkacat: fix missing version information
4c57942 
kafkacat currently requires checking out from git at build time
to show the correct version when running `kafkacat -v`

(see edenhill/kcat#92)
@xvrl xvrl mentioned this issue Apr 4, 2017
Closed
4 tasks
edenhill added a commit that referenced this issue Apr 20, 2017
@edenhill
Use default fallback version if built outside of git repo (#92)
0ab5204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edenhill