Support Fixed key #123
Merged
Support Fixed key #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
requested changes
Nov 6, 2017
kafkacat.c
Outdated
| @@ -350,6 +351,11 @@ static void producer_run (FILE *fp, char **paths, int pathcnt) { | |||
| } | |||
| } | |||
|
|
|||
| if (!key && conf.fixed_key) { | |||
| key = conf.fixed_key; | |||
| key_len = (size_t)(strlen(conf.fixed_key)); | |||
kafkacat.c
Outdated
| @@ -936,6 +942,7 @@ static void RD_NORETURN usage (const char *argv0, int exitcode, | |||
| " -p -1 Use random partitioner\n" | |||
| " -D <delim> Delimiter to split input into messages\n" | |||
| " -K <delim> Delimiter to split input key and message\n" | |||
| " -F <str> Use a fixed key for all messages\n" | |||
There was a problem hiding this comment.
I think -k would be more intuitive
There was a problem hiding this comment.
Agreed. Funny I didn't think of that alternative.
solsson
added a commit
to Yolean/kubernetes-kafka
that referenced
this pull request
Nov 6, 2017
Addresses #88 (comment). I deemed it safe to assume that operational daemonset pods never co-exist on a node. Tests edenhill/kcat#123, as does 53f355a.
solsson
added a commit
to Yolean/kubernetes-kafka
that referenced
this pull request
Nov 6, 2017
|
I've been running the build from after my review fixes, and see no regressions. |
|
Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use kafkacat in replicated containers, where a useful key is for example the machine that the particular container runs on, which I can get from environment variables. It makes more sense to set this key value at command invocation, than
seding the piped data.I remember nothing of the C we wrote in school, but I gave this a shot. If you like the idea but - as is likely - not the implementaton or the choice of flag, I'm happy to see a rewrite.
I've built this as solsson/kafkacat-fixedkey and tested it briefly for my usecases, including those with per-message keys from stdin.