Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github workflow to build containers #381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yselkowitz
Copy link

This workflow should automatically push a multi-arch container image build whenever a tag is created.

Fixes: #324

@rnsc
Copy link

rnsc commented May 3, 2022

@yselkowitz would it make sense to build without push on PR to check that it builds properly before merging?

@yselkowitz
Copy link
Author

That would be up to the maintainer, but 1) it looks like Travis CI is already being used for checking the code compilation, 2) it might be an overkill to cross-build the container for every PR (maybe that should be limited to Dockerfile changes only?), 3) the maintainer's Github Actions quota needs to be considered, and 4) perhaps to avoid abuse some protection should be put in place to avoid triggering CI builds for first-time contributors.

@yselkowitz
Copy link
Author

/cc @edenhill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-arch Docker build
2 participants