Skip to content

Commit

Permalink
refactor(webapp): improve health message and fix tooltip position
Browse files Browse the repository at this point in the history
  • Loading branch information
Torresmorah committed Dec 14, 2022
1 parent 8f556c8 commit 66795e8
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 11 deletions.
4 changes: 2 additions & 2 deletions webapp/src/components/HealthCheck/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const HealthCheck = ({ children, status }) => {
}

return (
<>
<div>
<div
className={classes.icon}
onClick={openPopOver}
Expand All @@ -43,7 +43,7 @@ const HealthCheck = ({ children, status }) => {
>
{children}
</Tooltip>
</>
</div>
)
}

Expand Down
5 changes: 2 additions & 3 deletions webapp/src/components/NodeCard/EndpointsChips.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,13 @@ const EndpointsChips = ({ node }) => {
case 'redLight':
return t('noneWorking')
default:
const beginning = t('noResponding')
const middle =
const beginning =
failingEndpoints.length > 1
? t('endpointPlural')
: t('endpointSingular')
const end = failingEndpoints.join(', ').toUpperCase()

return `${beginning} ${middle} ${end}`
return `${beginning} ${end}`
}
}

Expand Down
5 changes: 2 additions & 3 deletions webapp/src/language/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,8 @@
"supportedApis": "Supported APIs",
"allWorking": "All API and SSL endpoints are responding",
"noneWorking": "No API or SSL endpoints are responding",
"noResponding": "The no responding",
"endpointPlural": "endpoints are the",
"endpointSingular": "endpoint is the"
"endpointPlural": "Endpoints not responding are the",
"endpointSingular": "Endpoint not responding is the"
},
"producerHealthIndicatorsComponent": {
"hs_organization_name": "Name",
Expand Down
5 changes: 2 additions & 3 deletions webapp/src/language/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,8 @@
"supportedApis": "APIs Soportadas",
"allWorking": "Todos los endpoints API y SSL están respondiendo",
"noneWorking": "Ningún endpoint API o SSL está respondiendo",
"noResponding": "No responde",
"endpointPlural": "los endpoints de tipo",
"endpointSingular": "el endpoint de tipo"
"endpointPlural": "Los endpoints que no responden son los",
"endpointSingular": "El endpoint que no responde es el"
},
"producerHealthIndicatorsComponent": {
"hs_organization_name": "Nombre",
Expand Down

0 comments on commit 66795e8

Please sign in to comment.