Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/load bp jsons 1053 #1055

Merged
merged 7 commits into from
Nov 17, 2022
Merged

Fix/load bp jsons 1053 #1055

merged 7 commits into from
Nov 17, 2022

Conversation

Torresmorah
Copy link
Collaborator

Limit how many bpjsons are requested

What does this PR do?

  • Resolve Mainnet is not loading BP JSONs correctly #1053
  • Limit the number of BP JSONS requested to 100
  • Add a timeout when an endpoint of the array is requested
  • Don't use statService when stateHistoryPluginEndpoint is not provided, in that case it would be called after loading the data from the producers.

Steps to test

  1. Run the project locally
  2. Check that the producers that aren't in the top 100 don't have bp.json
    and those in the top have the object

Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit c1b59d0 into dev Nov 17, 2022
@xavier506 xavier506 deleted the fix/load-bp-jsons-1053 branch November 17, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mainnet is not loading BP JSONs correctly
2 participants