Feat/change the web link for icons or words #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a validation to see if values are empty and if they are, they dont show N/A, instead the title isnt shown at all. By default all BP will show Website and Email
AngeloCG97
requested changes
Nov 29, 2022
fvives99
requested review from
AngeloCG97,
xavier506,
Torresmorah and
Edwinjrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Steps to test
Added Icons to open website and option to copy URL
Only information that is available is visible (shows email and website as a placeholder until we wait for a Empty State)
Matching style for BP nodes section